Originally Posted by Amoc
Vayne says on hit is not dead.
You are playing Vayne wrong.
She has one (bad) skill that scales with attack speed, and then... AMAZING scaling with AD across 3 skills.
Let's look at the champions who are considered good for on-hit build:
Kog'Maw: Does better damage with AD, isn't expected to do anything early game, is safe so doesn't need survivability.
Kayle: Does better damage with AD, isn't expected to do anything early game, is safe so doesn't need survivability.
Teemo: Solo top, needs better sustain and survivability to live up there. Focused on kiting. Build Atmogs.
There's also the problem of Atmogs does similar damage, keeps you alive better, doesn't have the penetration problems, and actually lets you dedicate more slots to straight damage late game.